OSDN Git Service

crypto: certs: fix FIPS selftest dependency
authorArnd Bergmann <arnd@arndb.de>
Thu, 15 Dec 2022 17:02:52 +0000 (18:02 +0100)
committerJarkko Sakkinen <jarkko@kernel.org>
Mon, 13 Feb 2023 08:00:41 +0000 (10:00 +0200)
commit0f5d4a0b995faa6537c4de79973817a4f8da206a
tree3b19045563aa491f94ff766b3b423bc2fa4fbce3
parentceaa837f96adb69c0df0397937cd74991d5d821a
crypto: certs: fix FIPS selftest dependency

The selftest code is built into the x509_key_parser module, and depends
on the pkcs7_message_parser module, which in turn has a dependency on
the key parser, creating a dependency loop and a resulting link
failure when the pkcs7 code is a loadable module:

ld: crypto/asymmetric_keys/selftest.o: in function `fips_signature_selftest':
crypto/asymmetric_keys/selftest.c:205: undefined reference to `pkcs7_parse_message'
ld: crypto/asymmetric_keys/selftest.c:209: undefined reference to `pkcs7_supply_detached_data'
ld: crypto/asymmetric_keys/selftest.c:211: undefined reference to `pkcs7_verify'
ld: crypto/asymmetric_keys/selftest.c:215: undefined reference to `pkcs7_validate_trust'
ld: crypto/asymmetric_keys/selftest.c:219: undefined reference to `pkcs7_free_message'

Avoid this by only allowing the selftest to be enabled when either
both parts are loadable modules, or both are built-in.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
crypto/asymmetric_keys/Kconfig
crypto/asymmetric_keys/pkcs7_verify.c