OSDN Git Service

net: Don't take rtnl_lock() in wireless_nlevent_flush()
authorKirill Tkhai <ktkhai@virtuozzo.com>
Thu, 29 Mar 2018 16:20:44 +0000 (19:20 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 29 Mar 2018 17:47:53 +0000 (13:47 -0400)
commit10256debb918aea083d0ddada64d29014c642a7b
treeb7d0b2d3e6f7e844b3f401bd7c1a5a9716f9735b
parentf0b07bb151b098d291fd1fd71ef7a2df56fb124a
net: Don't take rtnl_lock() in wireless_nlevent_flush()

This function iterates over net_namespace_list and flushes
the queue for every of them. What does this rtnl_lock()
protects?! Since we may add skbs to net::wext_nlevents
without rtnl_lock(), it does not protects us about queuers.

It guarantees, two threads can't flush the queue in parallel,
that can change the order, but since skb can be queued
in any order, it doesn't matter, how many threads do this
in parallel. In case of several threads, this will be even
faster.

So, we can remove rtnl_lock() here, as it was used for
iteration over net_namespace_list only.

Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/wireless/wext-core.c