OSDN Git Service

gfs2: Put bitmap buffers in put_super
authorAndreas Gruenbacher <agruenba@redhat.com>
Mon, 5 Nov 2018 22:57:24 +0000 (22:57 +0000)
committerAndreas Gruenbacher <agruenba@redhat.com>
Fri, 9 Nov 2018 10:55:27 +0000 (10:55 +0000)
commit10283ea525d30f2e99828978fd04d8427876a7ad
tree7e8a13277f5a2f077ca9d3d67bbe6abfd2676e99
parent8e31582a9ab18093c0b7708b52d7f79eed9a8688
gfs2: Put bitmap buffers in put_super

gfs2_put_super calls gfs2_clear_rgrpd to destroy the gfs2_rgrpd objects
attached to the resource group glocks.  That function should release the
buffers attached to the gfs2_bitmap objects (bi_bh), but the call to
gfs2_rgrp_brelse for doing that is missing.

When gfs2_releasepage later runs across these buffers which are still
referenced, it refuses to free them.  This causes the pages the buffers
are attached to to remain referenced as well.  With enough mount/unmount
cycles, the system will eventually run out of memory.

Fix this by adding the missing call to gfs2_rgrp_brelse in
gfs2_clear_rgrpd.

(Also fix a gfs2_rgrp_relse -> gfs2_rgrp_brelse typo in a comment.)

Fixes: 39b0f1e92908 ("GFS2: Don't brelse rgrp buffer_heads every allocation")
Cc: stable@vger.kernel.org # v4.2+
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
fs/gfs2/rgrp.c