OSDN Git Service

scsi: esp_scsi: Track residual for PIO transfers
authorFinn Thain <fthain@telegraphics.com.au>
Tue, 16 Oct 2018 05:31:25 +0000 (16:31 +1100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 13 Nov 2018 19:08:32 +0000 (11:08 -0800)
commit1057c64748b615fdfdd28ea5ca0895675dca5e24
treef156609d5a9f7824cc4b41b405e0f5ff99d4f49e
parent1db5dec2dd69e6fcaf59ab6b151877c1119e3de7
scsi: esp_scsi: Track residual for PIO transfers

[ Upstream commit fd47d919d0c336e7c22862b51ee94927ffea227a ]

If a target disconnects during a PIO data transfer the command may fail
when the target reconnects:

scsi host1: DMA length is zero!
scsi host1: cur adr[04380000] len[00000000]

The scsi bus is then reset. This happens because the residual reached
zero before the transfer was completed.

The usual residual calculation relies on the Transfer Count registers.
That works for DMA transfers but not for PIO transfers. Fix the problem
by storing the PIO transfer residual and using that to correctly
calculate bytes_sent.

Fixes: 6fe07aaffbf0 ("[SCSI] m68k: new mac_esp scsi driver")
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/esp_scsi.c
drivers/scsi/esp_scsi.h
drivers/scsi/mac_esp.c