OSDN Git Service

xen-netback: take a reference to the RX task thread
authorRoger Pau Monne <roger.pau@citrix.com>
Mon, 7 Jun 2021 13:13:15 +0000 (15:13 +0200)
committerJuergen Gross <jgross@suse.com>
Mon, 7 Jun 2021 13:13:15 +0000 (15:13 +0200)
commit107866a8eb0b664675a260f1ba0655010fac1e08
tree8c48f10e20935f1d7bf2c725a5f053690db745ba
parentc81d3d24602540f65256f98831d0a25599ea6b87
xen-netback: take a reference to the RX task thread

Do this in order to prevent the task from being freed if the thread
returns (which can be triggered by the frontend) before the call to
kthread_stop done as part of the backend tear down. Not taking the
reference will lead to a use-after-free in that scenario. Such
reference was taken before but dropped as part of the rework done in
2ac061ce97f4.

Reintroduce the reference taking and add a comment this time
explaining why it's needed.

This is XSA-374 / CVE-2021-28691.

Fixes: 2ac061ce97f4 ('xen/netback: cleanup init and deinit code')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Cc: stable@vger.kernel.org
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
drivers/net/xen-netback/interface.c