OSDN Git Service

brcmfmac: fix leak of mypkt on error return path
authorColin Ian King <colin.king@canonical.com>
Tue, 9 Apr 2019 11:43:33 +0000 (12:43 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Jan 2020 13:50:38 +0000 (14:50 +0100)
commit10c588de85c1e94326e9dfa47cae4505fec53464
tree869b847dbb1aef44055bf830bf09b1b6ee429270
parent047b402d1ba3dad09070e4fb9acaf2c38a89ef0d
brcmfmac: fix leak of mypkt on error return path

[ Upstream commit a927e8d8ab57e696800e20cf09a72b7dfe3bbebb ]

Currently if the call to brcmf_sdiod_set_backplane_window fails then
error return path leaks mypkt. Fix this by returning by a new
error path labelled 'out' that calls brcmu_pkt_buf_free_skb to free
mypkt.  Also remove redundant check on err before calling
brcmf_sdiod_skbuff_write.

Addresses-Coverity: ("Resource Leak")
Fixes: a7c3aa1509e2 ("brcmfmac: Remove brcmf_sdiod_addrprep()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c