OSDN Git Service

net/sonic: Fix a resource leak in an error handling path in 'jazz_sonic_probe()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Mon, 27 Apr 2020 06:18:03 +0000 (08:18 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 27 Apr 2020 19:07:46 +0000 (12:07 -0700)
commit10e3cc180e64385edc9890c6855acf5ed9ca1339
treed2aad80e3002edbeb9fd189b3818a2380ff685bf
parent4b5b71f770e2edefbfe74203777264bfe6a9927c
net/sonic: Fix a resource leak in an error handling path in 'jazz_sonic_probe()'

A call to 'dma_alloc_coherent()' is hidden in 'sonic_alloc_descriptors()',
called from 'sonic_probe1()'.

This is correctly freed in the remove function, but not in the error
handling path of the probe function.
Fix it and add the missing 'dma_free_coherent()' call.

While at it, rename a label in order to be slightly more informative.

Fixes: efcce839360f ("[PATCH] macsonic/jazzsonic network drivers update")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/natsemi/jazzsonic.c