OSDN Git Service

regulator: wm831x: Fix notifier mutex lock warning
authorSteve Twiss <stwiss.opensource@diasemi.com>
Tue, 26 Feb 2019 15:48:46 +0000 (15:48 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 13 Mar 2019 15:10:56 +0000 (15:10 +0000)
commit119c4f5085c45b60cb23c5595e45d06135b89518
tree11b20d2b45f9f54f7aa3debaa8f77d90e6a0e28e
parent275513b7695a61b75b2546406ecd0f8e3d9fc8be
regulator: wm831x: Fix notifier mutex lock warning

The mutex for the regulator_dev must be controlled by the caller of
the regulator_notifier_call_chain(), as described in the comment
for that function.

Failure to mutex lock and unlock surrounding the notifier call results
in a kernel WARN_ON_ONCE() which will dump a backtrace for the
regulator_notifier_call_chain() when that function call is first made.
The mutex can be controlled using the regulator_lock/unlock() API.

Fixes: e4ee831f949a ("regulator: Add WM831x DC-DC buck convertor support")
Suggested-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/wm831x-dcdc.c