OSDN Git Service

8139too: revisit napi_complete_done() usage
authorEric Dumazet <edumazet@google.com>
Mon, 18 Sep 2017 20:03:43 +0000 (13:03 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 19 Sep 2017 03:57:00 +0000 (20:57 -0700)
commit129c6cda2de2a8ac44fab096152469999b727faf
treeee5c23d46331ab2fa2f9c10f0974872fe31a122e
parent4c7124413aa759b8ea0b90cd39177e525396e662
8139too: revisit napi_complete_done() usage

It seems we have to be more careful in napi_complete_done()
use. This patch is not a revert, as it seems we can
avoid bug that Ville reported by moving the napi_complete_done()
test in the spinlock section.

Many thanks to Ville for detective work and all tests.

Fixes: 617f01211baf ("8139too: use napi_complete_done()")
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Tested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/8139too.c