OSDN Git Service

bpf: Fix bpf_put_raw_tracepoint()'s use of __module_address()
authorAndrii Nakryiko <andrii@kernel.org>
Thu, 3 Dec 2020 20:46:21 +0000 (12:46 -0800)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 4 Dec 2020 01:38:20 +0000 (17:38 -0800)
commit12cc126df82c96c89706aa207ad27c56f219047c
tree481eb62be58a08f279c73fd34f2d9f9f16c786af
parentcadd64807cd83e2213dcb70f93d12d978c02b5fa
bpf: Fix bpf_put_raw_tracepoint()'s use of __module_address()

__module_address() needs to be called with preemption disabled or with
module_mutex taken. preempt_disable() is enough for read-only uses, which is
what this fix does. Also, module_put() does internal check for NULL, so drop
it as well.

Fixes: a38d1107f937 ("bpf: support raw tracepoints in modules")
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Link: https://lore.kernel.org/bpf/20201203204634.1325171-2-andrii@kernel.org
kernel/trace/bpf_trace.c