OSDN Git Service

hpsa: refine the pci enable/disable handling
authorTomas Henzl <thenzl@redhat.com>
Thu, 14 Aug 2014 14:12:39 +0000 (16:12 +0200)
committerChristoph Hellwig <hch@lst.de>
Tue, 16 Sep 2014 16:09:49 +0000 (09:09 -0700)
commit132aa220b45d60e9b20def1e9d8be9422eed9616
tree239084090915d462402b4566c04d35161f3594d7
parent9e0328453ea1a0e800b10daafffbadeac68273fd
hpsa: refine the pci enable/disable handling

When a second(kdump) kernel starts and the hard reset method is used
the driver calls pci_disable_device without previously enabling it,
so the kernel shows a warning -
[   16.876248] WARNING: at drivers/pci/pci.c:1431 pci_disable_device+0x84/0x90()
[   16.882686] Device hpsa
disabling already-disabled device
...
This patch fixes it, in addition to this I tried to balance also some other pairs
of enable/disable device in the driver.
Unfortunately I wasn't able to verify the functionality for the case of a sw reset,
because of a lack of proper hw.

Signed-off-by: Tomas Henzl <thenzl@redhat.com>
Reviewed-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/hpsa.c