OSDN Git Service

i3c: master: dw: check return of dw_i3c_master_get_free_pos()
authorTom Rix <trix@redhat.com>
Sat, 8 Jan 2022 15:09:48 +0000 (07:09 -0800)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 13 Jan 2022 01:05:50 +0000 (02:05 +0100)
commit13462ba1815db5a96891293a9cfaa2451f7bd623
treea5ed22167ccda1202bbbe7c7e3eacdc94ac7b611
parent7a2bccd1a27f0c8fc87e4ed56abd6ea9fa7314a6
i3c: master: dw: check return of dw_i3c_master_get_free_pos()

Clang static analysis reports this problem
dw-i3c-master.c:799:9: warning: The result of the left shift is
  undefined because the left operand is negative
                      COMMAND_PORT_DEV_INDEX(pos) |
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~

pos can be negative because dw_i3c_master_get_free_pos() can return an
error.  So check for an error.

Fixes: 1dd728f5d4d4 ("i3c: master: Add driver for Synopsys DesignWare IP")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20220108150948.3988790-1-trix@redhat.com
drivers/i3c/master/dw-i3c-master.c