OSDN Git Service

btrfs: volumes: Add comment for find_free_dev_extent_start()
authorQu Wenruo <wqu@suse.com>
Fri, 19 Jul 2019 06:51:42 +0000 (14:51 +0800)
committerDavid Sterba <dsterba@suse.com>
Mon, 9 Sep 2019 12:59:00 +0000 (14:59 +0200)
commit135da9766eea6134229146f6f67fdcbba41120e1
tree9cc949f9dbcb5c007064d13a819994871c8acb8a
parent9e3246a5f675932079cf4cc1818b7c1b02f93e36
btrfs: volumes: Add comment for find_free_dev_extent_start()

Since commit 6df9a95e6339 ("Btrfs: make the chunk allocator completely
tree lockless") we search commit root of device tree to avoid deadlock.

This introduced a safety feature, find_free_dev_extent_start() won't
use dev extents which just get freed in current transaction.

This safety feature makes sure we won't allocate new block group using
just freed dev extents to break CoW.

However, this feature also makes find_free_dev_extent_start() not
reliable reporting free device space.  Just add such comment to make
later viewer careful about this behavior.

This behavior makes one caller, btrfs_can_relocate() unreliable
determining the device free space.

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/volumes.c