OSDN Git Service

drm/i915/bios: fix a memory leak in generate_lfp_data_ptrs
authorXia Fukun <xiafukun@huawei.com>
Fri, 25 Nov 2022 06:34:28 +0000 (14:34 +0800)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Tue, 29 Nov 2022 17:30:14 +0000 (12:30 -0500)
commit1382901f75a5a7dc8eac05059fd0c7816def4eae
treeb2b86092ae46713759c77bcaa80e44a8857cacd0
parent35aba5f51a39fb95351844ffb14ec02b8970e19f
drm/i915/bios: fix a memory leak in generate_lfp_data_ptrs

When (size != 0 || ptrs->lvds_ entries != 3), the program tries to
free() the ptrs. However, the ptrs is not created by calling kzmalloc(),
but is obtained by pointer offset operation.
This may lead to memory leaks or undefined behavior.

Fix this by replacing the arguments of kfree() with ptrs_block.

Fixes: a87d0a847607 ("drm/i915/bios: Generate LFP data table pointers if the VBT lacks them")
Signed-off-by: Xia Fukun <xiafukun@huawei.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221125063428.69486-1-xiafukun@huawei.com
(cherry picked from commit 7674cd0b7d28b952151c3df26bbfa7e07eb2b4ec)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/i915/display/intel_bios.c