OSDN Git Service

regmap: Make regmap_noinc_read() return -ENOTSUPP if map->read isn't set
authorJavier Martinez Canillas <javierm@redhat.com>
Thu, 16 Jun 2022 07:34:34 +0000 (09:34 +0200)
committerMark Brown <broonie@kernel.org>
Fri, 24 Jun 2022 15:27:22 +0000 (16:27 +0100)
commit147b5fffc2cfa00956552f32e64c060d10d84010
treeb28492881830d5fed3838f7734c08a7214e33398
parentb688a7629c425d7916f9bde7fce8f7da2f852ceb
regmap: Make regmap_noinc_read() return -ENOTSUPP if map->read isn't set

Before adding support to define bulk read/write callbacks in regmap_config
by the commit d77e74561368 ("regmap: Add bulk read/write callbacks into
regmap_config"), the regmap_noinc_read() function returned an errno early
a map->bus->read callback wasn't set.

But that commit dropped the check and now a call to _regmap_raw_read() is
attempted even when bulk read operations are not supported. That function
checks for map->read anyways but there's no point to continue if the read
can't succeed.

Also is a fragile assumption to make so is better to make it fail earlier.

Fixes: d77e74561368 ("regmap: Add bulk read/write callbacks into regmap_config")
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://lore.kernel.org/r/20220616073435.1988219-3-javierm@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/base/regmap/regmap.c