OSDN Git Service

can: isotp: isotp_release(): omit unintended hrtimer restart on socket release
authorOliver Hartkopp <socketcan@hartkopp.net>
Fri, 18 Jun 2021 17:37:13 +0000 (19:37 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Sat, 19 Jun 2021 21:54:00 +0000 (23:54 +0200)
commit14a4696bc3118ba49da28f79280e1d55603aa737
tree0d45c20e707975956c63ccb4608d16b5fe5f291e
parentfb8696ab14adadb2e3f6c17c18ed26b3ecd96691
can: isotp: isotp_release(): omit unintended hrtimer restart on socket release

When closing the isotp socket, the potentially running hrtimers are
canceled before removing the subscription for CAN identifiers via
can_rx_unregister().

This may lead to an unintended (re)start of a hrtimer in
isotp_rcv_cf() and isotp_rcv_fc() in the case that a CAN frame is
received by isotp_rcv() while the subscription removal is processed.

However, isotp_rcv() is called under RCU protection, so after calling
can_rx_unregister, we may call synchronize_rcu in order to wait for
any RCU read-side critical sections to finish. This prevents the
reception of CAN frames after hrtimer_cancel() and therefore the
unintended (re)start of the hrtimers.

Link: https://lore.kernel.org/r/20210618173713.2296-1-socketcan@hartkopp.net
Fixes: e057dd3fc20f ("can: add ISO 15765-2:2016 transport protocol")
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
net/can/isotp.c