OSDN Git Service

drm/amdgpu/dm/dp_mst: Don't grab mst_mgr->lock when computing DSC state
authorLyude Paul <lyude@redhat.com>
Mon, 14 Nov 2022 22:17:55 +0000 (17:17 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 17 Nov 2022 05:23:00 +0000 (00:23 -0500)
commit14b651b22224251b35618259da714adb0b5f10ee
tree625a46b7fc6914e01285a080179b92512dce53c9
parentd3e2c664ec9a3b16a28b558d6d1acde6d997ac04
drm/amdgpu/dm/dp_mst: Don't grab mst_mgr->lock when computing DSC state

Now that we've fixed the issue with using the incorrect topology manager,
we're actually grabbing the topology manager's lock - and consequently
deadlocking. Luckily for us though, there's actually nothing in AMD's DSC
state computation code that really should need this lock. The one exception
is the mutex_lock() in dm_dp_mst_is_port_support_mode(), however we grab no
locks beneath &mgr->lock there so that should be fine to leave be.

Gitlab issue: https://gitlab.freedesktop.org/drm/amd/-/issues/2171

Signed-off-by: Lyude Paul <lyude@redhat.com>
Fixes: 8c20a1ed9b4f ("drm/amd/display: MST DSC compute fair share")
Cc: <stable@vger.kernel.org> # v5.6+
Reviewed-by: Wayne Lin <Wayne.Lin@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c