OSDN Git Service

net/ipv6: don't return positive numbers when nothing was dumped
authorJakub Kicinski <jakub.kicinski@netronome.com>
Tue, 22 Jan 2019 22:47:19 +0000 (14:47 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 23 Jan 2019 01:24:18 +0000 (17:24 -0800)
commit1518039f6b5ac794313c24c76f85cead0cd60f6c
tree1ade65e4d0b8b45670a7de1b0d045b6e7b3c509b
parentcb73ee40b1b381eaf3749e6dbeed567bb38e5258
net/ipv6: don't return positive numbers when nothing was dumped

in6_dump_addrs() returns a positive 1 if there was nothing to dump.
This return value can not be passed as return from inet6_dump_addr()
as is, because it will confuse rtnetlink, resulting in NLMSG_DONE
never getting set:

$ ip addr list dev lo
EOF on netlink
Dump terminated

v2: flip condition to avoid a new goto (DaveA)

Fixes: 7c1e8a3817c5 ("netlink: fixup regression in RTM_GETADDR")
Reported-by: Brendan Galloway <brendan.galloway@netronome.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Tested-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/addrconf.c