OSDN Git Service

gma500: clean up error handling in init
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 3 Dec 2020 08:40:48 +0000 (11:40 +0300)
committerPatrik Jakobsson <patrik.r.jakobsson@gmail.com>
Thu, 3 Dec 2020 09:50:57 +0000 (10:50 +0100)
commit15ccc39b3aab667c6fa131206f01f31bfbccdf6a
tree7289c9411370744ef5efa186be57ce5b29cec667
parente4401247070a37c2fce62b2773a4eb7757983938
gma500: clean up error handling in init

The main problem with this error handling was that it didn't clean up if
i2c_add_numbered_adapter() failed.  This code is pretty old, and doesn't
match with today's checkpatch.pl standards so I took the opportunity to
tidy it up a bit.  I changed the NULL comparison, and removed the
WARNING message if kzalloc() fails and updated the label names.

Fixes: 1b082ccf5901 ("gma500: Add Oaktrail support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/X8ikkAqZfnDO2lu6@mwanda
drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c