OSDN Git Service

hwmon: (ina2xx) Fix current value calculation
authorNicolin Chen <nicoleotsuka@gmail.com>
Wed, 14 Nov 2018 03:48:54 +0000 (19:48 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Dec 2018 20:55:10 +0000 (21:55 +0100)
commit15d8d7246173d11e7b75e34bc0226682468f9a8c
tree88959a0ea1239eb159e00f8613ef7a2d4e4a31b6
parent9ba7a303ff290d21bade27317337505640e556c0
hwmon: (ina2xx) Fix current value calculation

[ Upstream commit 38cd989ee38c16388cde89db5b734f9d55b905f9 ]

The current register (04h) has a sign bit at MSB. The comments
for this calculation also mention that it's a signed register.

However, the regval is unsigned type so result of calculation
turns out to be an incorrect value when current is negative.

This patch simply fixes this by adding a casting to s16.

Fixes: 5d389b125186c ("hwmon: (ina2xx) Make calibration register value fixed")
Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hwmon/ina2xx.c