OSDN Git Service

can: j1939: j1939_tp_cmd_recv(): check the dst address of TP.CM_BAM
authorZhang Changzhong <zhangchangzhong@huawei.com>
Thu, 28 Oct 2021 14:38:27 +0000 (22:38 +0800)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Sat, 6 Nov 2021 16:29:32 +0000 (17:29 +0100)
commit164051a6ab5445bd97f719f50b16db8b32174269
treeee8733528ae40c77f0c9b3e43518734ba4b86611
parenta79305e156db3d24fcd8eb649cdb3c3b2350e5c2
can: j1939: j1939_tp_cmd_recv(): check the dst address of TP.CM_BAM

The TP.CM_BAM message must be sent to the global address [1], so add a
check to drop TP.CM_BAM sent to a non-global address.

Without this patch, the receiver will treat the following packets as
normal RTS/CTS transport:
18EC0102#20090002FF002301
18EB0102#0100000000000000
18EB0102#020000FFFFFFFFFF

[1] SAE-J1939-82 2015 A.3.3 Row 1.

Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
Link: https://lore.kernel.org/all/1635431907-15617-4-git-send-email-zhangchangzhong@huawei.com
Cc: stable@vger.kernel.org
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
net/can/j1939/transport.c