OSDN Git Service

block/fuse: Let PUNCH_HOLE write zeroes
authorHanna Czenczek <hreitz@redhat.com>
Mon, 27 Feb 2023 10:47:24 +0000 (11:47 +0100)
committerKevin Wolf <kwolf@redhat.com>
Fri, 10 Mar 2023 14:14:46 +0000 (15:14 +0100)
commit1703eb1c27a6010ff33d5add2d76aadc9b2777bd
treeacd0f4c0d0842e9c8b9288687a037b27de529e1b
parentee59483267de29056b5b2ee2421ef3844e5c9932
block/fuse: Let PUNCH_HOLE write zeroes

fallocate(2) says about PUNCH_HOLE: "After a successful call, subsequent
reads from this range will return zeros."  As it is, PUNCH_HOLE is
implemented as a call to blk_pdiscard(), which does not guarantee this.

We must call blk_pwrite_zeroes() instead.  The difference to ZERO_RANGE
is that we pass the `BDRV_REQ_MAY_UNMAP | BDRV_REQ_NO_FALLBACK` flags to
the call -- the storage is supposed to be unmapped, and a slow fallback
by actually writing zeroes as data is not allowed.

Closes: https://gitlab.com/qemu-project/qemu/-/issues/1507
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230227104725.33511-2-hreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block/export/fuse.c