OSDN Git Service

usb: renesas_usbhs: missed the "running" flag in usb_dmac with rx path
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Mon, 5 Feb 2018 08:12:35 +0000 (17:12 +0900)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Mon, 12 Feb 2018 08:56:37 +0000 (10:56 +0200)
commit17aa31f13cad25daa19d3f923323f552e87bc874
treea29e061d4c8dcc8b799fe5661393577b6c35b56c
parent20bf410ecf9e9c045f4b0548d516dd3de8691074
usb: renesas_usbhs: missed the "running" flag in usb_dmac with rx path

This fixes an issue that a gadget driver (usb_f_fs) is possible to
stop rx transactions after the usb-dmac is used because the following
functions missed to set/check the "running" flag.
 - usbhsf_dma_prepare_pop_with_usb_dmac()
 - usbhsf_dma_pop_done_with_usb_dmac()

So, if next transaction uses pio, the usbhsf_prepare_pop() can not
start the transaction because the "running" flag is 0.

Fixes: 8355b2b3082d ("usb: renesas_usbhs: fix the behavior of some usbhs_pkt_handle")
Cc: <stable@vger.kernel.org> # v3.19+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/renesas_usbhs/fifo.c