OSDN Git Service

drm/i915: Only the zap the VMA after updating the tiling parameters
authorChris Wilson <chris@chris-wilson.co.uk>
Sat, 21 Apr 2012 15:23:24 +0000 (16:23 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 3 May 2012 09:18:07 +0000 (11:18 +0200)
commit1869b620d27a0e353bd6558015713fad2d0cc09b
tree632943f4381d72d4165f7abf9046842effb3535f
parent5d82e3e6427d407e5e4713a2f73210b4e7801ad3
drm/i915: Only the zap the VMA after updating the tiling parameters

If we fail to unbind and so abort the change in tiling, we will have
removed the VMA for the object for no reason. The likelihood of unbind
failing is slim (other than ERESTARTSYS which will cause userspace to
try again), so the change is mostly for the principle.

Also improve the slightly stale comment.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_gem_tiling.c