OSDN Git Service

KVM: arm64: Fix misuse of KVM_ARM_VCPU_POWER_OFF bit index
authorOliver Upton <oliver.upton@linux.dev>
Thu, 22 Jun 2023 16:09:22 +0000 (16:09 +0000)
committerOliver Upton <oliver.upton@linux.dev>
Thu, 22 Jun 2023 17:17:14 +0000 (17:17 +0000)
commit192df2aa0113ddddee2a93e453ff46610807b425
tree31fba9a3378b132bbb5ba28908e933fc8ffd85e1
parent92d05e2492f1400029e84b5a72e15811ef787ee9
KVM: arm64: Fix misuse of KVM_ARM_VCPU_POWER_OFF bit index

KVM_ARM_VCPU_POWER_OFF is as bit index, _not_ a literal bitmask.
Nonetheless, commit e3c1c0cae31e ("KVM: arm64: Relax invariance
of KVM_ARM_VCPU_POWER_OFF") started using it that way, meaning that
powering off a vCPU with the KVM_ARM_VCPU_INIT ioctl is completely
broken.

Fix it by using a shifted bit for the bitwise operations instead.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Fixes: e3c1c0cae31e ("KVM: arm64: Relax invariance of KVM_ARM_VCPU_POWER_OFF")
Acked-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20230622160922.1925530-1-oliver.upton@linux.dev
Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
arch/arm64/kvm/arm.c