OSDN Git Service

[Remarks] Silence gcc warning by catching unhandled values in switches
authorMikael Holmen <mikael.holmen@ericsson.com>
Thu, 4 Jul 2019 09:29:18 +0000 (09:29 +0000)
committerMikael Holmen <mikael.holmen@ericsson.com>
Thu, 4 Jul 2019 09:29:18 +0000 (09:29 +0000)
commit1934a3e523817e1f26701f65120d7961176ffc56
treebe306b0339656c63bdfb564255e8527be2203974
parent963f1fa4ace25fc1198d92efd8a42de64157cb55
[Remarks] Silence gcc warning by catching unhandled values in switches

Without this fix gcc (7.4) complains with
 ../lib/Remarks/RemarkParser.cpp: In function 'std::unique_ptr<llvm::remarks::ParserImpl> formatToParserImpl(llvm::remarks::ParserFormat, llvm::StringRef)':
 ../lib/Remarks/RemarkParser.cpp:29:1: error: control reaches end of non-void function [-Werror=return-type]
  }
  ^
 ../lib/Remarks/RemarkParser.cpp: In function 'std::unique_ptr<llvm::remarks::ParserImpl> formatToParserImpl(llvm::remarks::ParserFormat, llvm::StringRef, const llvm::remarks::ParsedStringTable&)':
 ../lib/Remarks/RemarkParser.cpp:38:1: error: control reaches end of non-void function [-Werror=return-type]
  }
  ^

The Format enum currently only contains the value YAML which is indeed
already handled in the switches, but gcc complains anyway.

Adding a default case with an llvm_unreachable silences gcc.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@365118 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Remarks/RemarkParser.cpp