OSDN Git Service

scsi: sd: Keep disk read-only when re-reading partition
authorJeremy Cline <jeremy@jcline.org>
Tue, 6 Mar 2018 21:47:32 +0000 (21:47 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 May 2018 05:49:04 +0000 (07:49 +0200)
commit1a11d73661a18a7265fa96fb2ed941375ca1fa10
tree3655d6944d9c346fc97acbdf548a5e73329cb955
parent5a5d9c70336819f3b8fc67959de4406c4290e1be
scsi: sd: Keep disk read-only when re-reading partition

[ Upstream commit 20bd1d026aacc5399464f8328f305985c493cde3 ]

If the read-only flag is true on a SCSI disk, re-reading the partition
table sets the flag back to false.

To observe this bug, you can run:

1. blockdev --setro /dev/sda
2. blockdev --rereadpt /dev/sda
3. blockdev --getro /dev/sda

This commit reads the disk's old state and combines it with the device
disk-reported state rather than unconditionally marking it as RW.

Reported-by: Li Ning <lining916740672@icloud.com>
Signed-off-by: Jeremy Cline <jeremy@jcline.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/sd.c