OSDN Git Service

crypto: drop mask=CRYPTO_ALG_ASYNC from 'cipher' tfm allocations
authorEric Biggers <ebiggers@google.com>
Wed, 14 Nov 2018 20:19:39 +0000 (12:19 -0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Tue, 20 Nov 2018 06:26:55 +0000 (14:26 +0800)
commit1ad0f1603a6b2afb62a1c065409aaa4e43ca7627
treedbc2b8fbc9998f36e8d079c585da7786d53eeda0
parentd41655909e3236bfb00aa69f435a9634cd74b60b
crypto: drop mask=CRYPTO_ALG_ASYNC from 'cipher' tfm allocations

'cipher' algorithms (single block ciphers) are always synchronous, so
passing CRYPTO_ALG_ASYNC in the mask to crypto_alloc_cipher() has no
effect.  Many users therefore already don't pass it, but some still do.
This inconsistency can cause confusion, especially since the way the
'mask' argument works is somewhat counterintuitive.

Thus, just remove the unneeded CRYPTO_ALG_ASYNC flags.

This patch shouldn't change any actual behavior.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
14 files changed:
arch/s390/crypto/aes_s390.c
drivers/crypto/amcc/crypto4xx_alg.c
drivers/crypto/ccp/ccp-crypto-aes-cmac.c
drivers/crypto/geode-aes.c
drivers/md/dm-crypt.c
drivers/net/wireless/cisco/airo.c
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c
drivers/usb/wusbcore/crypto.c
net/bluetooth/smp.c
net/mac80211/wep.c
net/wireless/lib80211_crypt_ccmp.c
net/wireless/lib80211_crypt_tkip.c
net/wireless/lib80211_crypt_wep.c