OSDN Git Service

bnx2x: prevent crash when accessing PTP with interface down
authorMichal Schmidt <mschmidt@redhat.com>
Fri, 3 Mar 2017 16:08:28 +0000 (17:08 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 16 Dec 2017 09:33:53 +0000 (10:33 +0100)
commit1aead0538b89f3c69457ea9fa50b7baca5894ef5
tree460b0ea0104c9a1e9600a624e16de833d4ce66e3
parent6bbc908cfc1ce230fe14ae00b316f427e77a56d1
bnx2x: prevent crash when accessing PTP with interface down

[ Upstream commit 466e8bf10ac104d96e1ea813e8126e11cb72ea20 ]

It is possible to crash the kernel by accessing a PTP device while its
associated bnx2x interface is down. Before the interface is brought up,
the timecounter is not initialized, so accessing it results in NULL
dereference.

Fix it by checking if the interface is up.

Use -ENETDOWN as the error code when the interface is down.
 -EFAULT in bnx2x_ptp_adjfreq() did not seem right.

Tested using phc_ctl get/set/adj/freq commands.

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c