OSDN Git Service

scsi: snic: Fix double free in snic_tgt_create()
authorZhu Wang <wangzhu9@huawei.com>
Sat, 19 Aug 2023 08:39:41 +0000 (08:39 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 25 Aug 2023 02:30:32 +0000 (22:30 -0400)
commit1bd3a76880b2bce017987cf53780b372cf59528e
treebaa0b623189b409001a934d6d14335657b0b2ce8
parent60c5fd2e8f3c42a5abc565ba9876ead1da5ad2b7
scsi: snic: Fix double free in snic_tgt_create()

Commit 41320b18a0e0 ("scsi: snic: Fix possible memory leak if device_add()
fails") fixed the memory leak caused by dev_set_name() when device_add()
failed. However, it did not consider that 'tgt' has already been released
when put_device(&tgt->dev) is called. Remove kfree(tgt) in the error path
to avoid double free of 'tgt' and move put_device(&tgt->dev) after the
removed kfree(tgt) to avoid a use-after-free.

Fixes: 41320b18a0e0 ("scsi: snic: Fix possible memory leak if device_add() fails")
Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
Link: https://lore.kernel.org/r/20230819083941.164365-1-wangzhu9@huawei.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/snic/snic_disc.c