OSDN Git Service

macvlan: use skb_reset_mac_header() in macvlan_queue_xmit()
authorEric Dumazet <edumazet@google.com>
Tue, 14 Jan 2020 21:00:35 +0000 (13:00 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Jan 2020 07:18:40 +0000 (08:18 +0100)
commit1bf5a3b07a5031b007ad70a5286304d1668c92ba
tree7e5fadfa820a3fdc7310889286c84591c1cac61d
parent5dd3cd576f5e4418823a514b8dfce3c617537382
macvlan: use skb_reset_mac_header() in macvlan_queue_xmit()

[ Upstream commit 1712b2fff8c682d145c7889d2290696647d82dab ]

I missed the fact that macvlan_broadcast() can be used both
in RX and TX.

skb_eth_hdr() makes only sense in TX paths, so we can not
use it blindly in macvlan_broadcast()

Fixes: 96cc4b69581d ("macvlan: do not assume mac_header is set in macvlan_broadcast()")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Jurgen Van Ham <juvanham@gmail.com>
Tested-by: Matteo Croce <mcroce@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/macvlan.c