OSDN Git Service

ASoC: soc-pcm/soc-compress: don't use snd_soc_dapm_stream_stop()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Fri, 21 Feb 2020 01:25:18 +0000 (10:25 +0900)
committerMark Brown <broonie@kernel.org>
Mon, 24 Feb 2020 20:34:06 +0000 (20:34 +0000)
commit1c5312308c96556ae209e8eb1423c38d4a113759
treed98ea891ed839fd8b545ec147925be42a05418bb
parent22946f37557e27697aabc8e4f62642bfe4a17fd8
ASoC: soc-pcm/soc-compress: don't use snd_soc_dapm_stream_stop()

commit b0edff42360ab4 ("ASoC: soc-pcm/soc-compress: use
snd_soc_dapm_stream_stop() for SND_SOC_DAPM_STREAM_STOP")
uses snd_soc_dapm_stream_stop() for soc_compr_free_fe()
and dpcm_fe_dai_shutdown() because it didn't care about pmdown_time.
But, it didn't need to care.
This patch rollback to original code.
Some system will wait unneeded timed-out without this patch.
Special Thanks for reporting to Chris Gorman.
...
intel_sst_acpi 808622A8:00: Wait timed-out condition:0x0, msg_id:0x1 fw_state 0x3
intel_sst_acpi 808622A8:00: fw returned err -16
sst-mfld-platform sst-mfld-platform: ASoC: PRE_PMD: pcm0_in event failed: -16
...

Fixes: commit b0edff42360ab4 ("ASoC: soc-pcm/soc-compress: use snd_soc_dapm_stream_stop() for SND_SOC_DAPM_STREAM_STOP")
Reported-by: Chris Gorman <chrisjohgorman@gmail.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87lfowspeb.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-compress.c
sound/soc/soc-pcm.c