OSDN Git Service

drm/amd/display: reduce else-if to else in dcn32_calculate_dlg_params()
authorTom Rix <trix@redhat.com>
Thu, 26 Jan 2023 20:49:35 +0000 (12:49 -0800)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 3 Feb 2023 20:38:15 +0000 (15:38 -0500)
commit1c6d24b8be0cbe8e9a573d069c16fe8a56af6a4f
tree51e424a877a4f3fa01c0f5222e68c5f03e62ae27
parent67cdd3a5cc03591a98a303e5e2086a470650967f
drm/amd/display: reduce else-if to else in dcn32_calculate_dlg_params()

cppcheck reports
drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c:1403:76: style:
  Expression is always true because 'else if' condition is opposite to previous condition at line 1396. [multiCondition]
   } else if (context->res_ctx.pipe_ctx[i].stream->mall_stream_config.type == SUBVP_PHANTOM) {
                                                                           ^
drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c:1396:69: note: first condition
   if (context->res_ctx.pipe_ctx[i].stream->mall_stream_config.type != SUBVP_PHANTOM) {
                                                                    ^
drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c:1403:76: note: else if condition is opposite to first condition
   } else if (context->res_ctx.pipe_ctx[i].stream->mall_stream_config.type == SUBVP_PHANTOM) {

It is not necessary to explicitly the check != condition, an else is simplier.

Fixes: 238debcaebe4 ("drm/amd/display: Use DML for MALL SS and Subvp allocation calculations")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c