OSDN Git Service

media: mc-request.c: allow object_bind in QUEUED state
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Wed, 2 Jun 2021 08:42:28 +0000 (10:42 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 2 Jun 2021 09:41:54 +0000 (11:41 +0200)
commit1cb13613735a15b994b680ae5ef18aaf79108b95
tree067ccf5cfdcaba6a8aea0b6b20476f84b8eefdce
parentb998a59f82f1152605eae4f7617778020549e81a
media: mc-request.c: allow object_bind in QUEUED state

If a request was queued without a control handler object, and
a control handler object is then created and bound to the request
when copying controls on request completion, then a WARN_ON in
mc-request.c is triggered since at that time the request is in
state QUEUED, and not UPDATING.

But this is too strict, and in this case it must also allow
binding objects when in state QUEUED.

This patch was unfortunately lost when the "always copy the controls
on completion" patch was posted, it should have been part of that
commit.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Fixes: c3bf5129f339 ("media: v4l2-ctrls: always copy the controls on completion")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/mc/mc-request.c