OSDN Git Service

video: hyperv_fb: Avoid taking busy spinlock on panic path
authorGuilherme G. Piccoli <gpiccoli@igalia.com>
Fri, 19 Aug 2022 22:17:29 +0000 (19:17 -0300)
committerWei Liu <wei.liu@kernel.org>
Mon, 28 Nov 2022 16:48:20 +0000 (16:48 +0000)
commit1d044ca035dc22df0d3b39e56f2881071d9118bd
treec7ace6be93408f78f779b32a09532a92efbeb1b2
parentdc60f2db39c3f8da4490c1ed827022bbc925d81c
video: hyperv_fb: Avoid taking busy spinlock on panic path

The Hyper-V framebuffer code registers a panic notifier in order
to try updating its fbdev if the kernel crashed. The notifier
callback is straightforward, but it calls the vmbus_sendpacket()
routine eventually, and such function takes a spinlock for the
ring buffer operations.

Panic path runs in atomic context, with local interrupts and
preemption disabled, and all secondary CPUs shutdown. That said,
taking a spinlock might cause a lockup if a secondary CPU was
disabled with such lock taken. Fix it here by checking if the
ring buffer spinlock is busy on Hyper-V framebuffer panic notifier;
if so, bail-out avoiding the potential lockup scenario.

Cc: Andrea Parri (Microsoft) <parri.andrea@gmail.com>
Cc: Dexuan Cui <decui@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Michael Kelley <mikelley@microsoft.com>
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Cc: Tianyu Lan <Tianyu.Lan@microsoft.com>
Cc: Wei Liu <wei.liu@kernel.org>
Tested-by: Fabio A M Martins <fabiomirmar@gmail.com>
Signed-off-by: Guilherme G. Piccoli <gpiccoli@igalia.com>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Link: https://lore.kernel.org/r/20220819221731.480795-10-gpiccoli@igalia.com
Signed-off-by: Wei Liu <wei.liu@kernel.org>
drivers/hv/ring_buffer.c
drivers/video/fbdev/hyperv_fb.c
include/linux/hyperv.h