OSDN Git Service

msm: camera: Remove useless NULL checks in msm_flash_i2c_release
authorNathan Chancellor <natechancellor@gmail.com>
Fri, 27 Sep 2019 05:57:52 +0000 (22:57 -0700)
committerNathan Chancellor <natechancellor@gmail.com>
Fri, 27 Sep 2019 07:42:36 +0000 (00:42 -0700)
commit1d7f0b6416a38b05ba80ada1ccf98b2826641865
tree6cc13043ef74d62dfa659a118166cc5ed2da08dc
parentb822a330e417e67e8e8937df949f187cac2039b6
msm: camera: Remove useless NULL checks in msm_flash_i2c_release

Clang warns:

../drivers/media/platform/msm/camera_v2/sensor/flash/msm_flash.c:366:21:
warning: address of 'flash_ctrl->power_info' will always evaluate to
'true' [-Wpointer-bool-conversion]
        if (!(&flash_ctrl->power_info) || !(&flash_ctrl->flash_i2c_client)) {
            ~  ~~~~~~~~~~~~^~~~~~~~~~
../drivers/media/platform/msm/camera_v2/sensor/flash/msm_flash.c:366:51:
warning: address of 'flash_ctrl->flash_i2c_client' will always evaluate
to 'true' [-Wpointer-bool-conversion]
        if (!(&flash_ctrl->power_info) || !(&flash_ctrl->flash_i2c_client)) {
                                          ~  ~~~~~~~~~~~~^~~~~~~~~~~~~~~~
2 warnings generated.

While we are at it, remove rc's useless assignment to zero.

Fixes: 12d7df3314bf ("msm: camera: Add all camera drivers")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
drivers/media/platform/msm/camera_v2/sensor/flash/msm_flash.c