OSDN Git Service

io: mark mixed functions that can suspend
authorPaolo Bonzini <pbonzini@redhat.com>
Fri, 16 Dec 2022 11:47:58 +0000 (12:47 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Thu, 20 Apr 2023 09:17:35 +0000 (11:17 +0200)
commit1dd91b22a620616cad08bee7efc29280121ff0da
tree6cf38ed8ffeba6f3d8b9821eda8fe758924cd6d1
parentcf9d4e68d7bcd333d59d2f3ff876b86dec00281a
io: mark mixed functions that can suspend

There should be no paths from a coroutine_fn to aio_poll, however in
practice coroutine_mixed_fn will call aio_poll in the !qemu_in_coroutine()
path.  By marking mixed functions, we can track accurately the call paths
that execute entirely in coroutine context, and find more missing
coroutine_fn markers.  This results in more accurate checks that
coroutine code does not end up blocking.

If the marking were extended transitively to all functions that call
these ones, static analysis could be done much more efficiently.
However, this is a start and makes it possible to use vrc's path-based
searches to find potential bugs where coroutine_fns call blocking functions.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
include/io/channel.h
io/channel.c