OSDN Git Service

PCI: xgene: Fix double free on init error
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 21 Jan 2017 04:49:49 +0000 (07:49 +0300)
committerBjorn Helgaas <bhelgaas@google.com>
Tue, 31 Jan 2017 00:17:05 +0000 (18:17 -0600)
commit1ded56df3247d358390ae6dc09ccee620262ac5f
tree45599518271ae46367189f458763127c5ba2b969
parent7ce7d89f48834cefece7804d38fc5d85382edf77
PCI: xgene: Fix double free on init error

The "port" variable was allocated with devm_kzalloc() so if we free it with
kfree() it will be freed twice.  Also I changed it to propogate the error
from devm_ioremap_resource() instead of returning -ENOMEM.

Fixes: c5d460396100 ("PCI: Add MCFG quirks for X-Gene host controller")
Also-posted-by: Shawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Tanmay Inamdar <tinamdar@apm.com>
drivers/pci/host/pci-xgene.c