OSDN Git Service

Fix ConnectivityServiceTest#testNetworkCallbackMaximum
authorHugo Benichi <hugobenichi@google.com>
Thu, 12 Oct 2017 14:09:25 +0000 (23:09 +0900)
committerHugo Benichi <hugobenichi@google.com>
Thu, 12 Oct 2017 14:15:14 +0000 (23:15 +0900)
commit1e5039e0e47eaca3bbe5452f8328c26756468e46
treea9f75f66718e81142ee86fa87b59d025221f7076
parentda7edaff329e84ce7b9d3cb2b4699520aed21594
Fix ConnectivityServiceTest#testNetworkCallbackMaximum

Although commit 893a762c2f7 fixed some flakyness issues in
testNetworkCallbackMaximum so that it became stable when ran on its own,
it introduced a new source of random failures because instead of
registering callbacks after callbacks until a limit was reached, commit
893a762c2f7 changed the test logic to push the assertions right up to
the theoretical limit.

More precisely when registering and unregistering PendingIntents in a
loop, not introducing some delay for checking that previous
PendingIntents have been effectively unregistered can cause the test to
fail. This patch fixes this issue.

Bug: 32561414
Bug: 62918393
Test: runtest frameworks-net
      testNetworkCallbackMaximum now succeeds 100 in a row on sailfish

Change-Id: I086817a738ab99fd53ba76ca8faada6151f46472
tests/net/java/com/android/server/ConnectivityServiceTest.java