OSDN Git Service

x86/platform/uv: Refactor code using deprecated strcpy()/strncpy() interfaces to...
authorJustin Stitt <justinstitt@google.com>
Thu, 24 Aug 2023 18:52:18 +0000 (18:52 +0000)
committerIngo Molnar <mingo@kernel.org>
Thu, 24 Aug 2023 19:22:06 +0000 (21:22 +0200)
commit1e6f01f7285559a5302e85677b8e59a5de9b0ea5
treeebf3313eff6c8baea7dd10ac222b9af5afdf87d8
parent8874a414f8f706daf1de467cbf2550988ebec09d
x86/platform/uv: Refactor code using deprecated strcpy()/strncpy() interfaces to use strscpy()

Both `strncpy` and `strcpy` are deprecated for use on NUL-terminated
destination strings [1].

A suitable replacement is `strscpy` [2] due to the fact that it
guarantees NUL-termination on its destination buffer argument which is
_not_ the case for `strncpy` or `strcpy`!

In this case, we can drop both the forced NUL-termination and the `... -1` from:
|       strncpy(arg, val, ACTION_LEN - 1);
as `strscpy` implicitly has this behavior.

Also include slight refactor to code removing possible new-line chars as
per Yang Yang's work at [3]. This reduces code size and complexity by
using more robust and better understood interfaces.

Co-developed-by: Yang Yang <yang.yang29@zte.com.cn>
Signed-off-by: Justin Stitt <justinstitt@google.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Dimitri Sivanich <sivanich@hpe.com>
Link: www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings[1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html
Link: https://lore.kernel.org/all/202212091545310085328@zte.com.cn/
Link: https://github.com/KSPP/linux/issues/90
Link: https://lore.kernel.org/r/20230824-strncpy-arch-x86-platform-uv-uv_nmi-v2-1-e16d9a3ec570@google.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/platform/uv/uv_nmi.c