OSDN Git Service

COLO-compare: Fix incorrect `if` logic
authorFan Yang <Fan_Yang@sjtu.edu.cn>
Tue, 24 Sep 2019 14:08:29 +0000 (22:08 +0800)
committerJason Wang <jasowang@redhat.com>
Tue, 29 Oct 2019 02:28:07 +0000 (10:28 +0800)
commit1e907a32b77e5d418538453df5945242e43224fa
tree86b1154f7d56546dc08bff1ca9e9113929effeed
parent7788c3f2e21e35902d45809b236791383bbb613e
COLO-compare: Fix incorrect `if` logic

'colo_mark_tcp_pkt' should return 'true' when packets are the same, and
'false' otherwise.  However, it returns 'true' when
'colo_compare_packet_payload' returns non-zero while
'colo_compare_packet_payload' is just a 'memcmp'.  The result is that
COLO-compare reports inconsistent TCP packets when they are actually
the same.

Fixes: f449c9e549c ("colo: compare the packet based on the tcp sequence number")
Cc: qemu-stable@nongnu.org
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Fan Yang <Fan_Yang@sjtu.edu.cn>
Signed-off-by: Jason Wang <jasowang@redhat.com>
net/colo-compare.c