OSDN Git Service

Revert "net-loopback: set lo dev initial state to UP"
authorPetr Machata <petrm@nvidia.com>
Tue, 9 Feb 2021 17:52:04 +0000 (18:52 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 11 Feb 2021 21:10:44 +0000 (13:10 -0800)
commit1edb5cbf49a7464a575966ad6f48b3876fb64f63
tree1b3ba91d447dcdd23aace1d865b513f18e19630d
parent4217a64e18a1647a0dbc68cb3169a5a06f054ec8
Revert "net-loopback: set lo dev initial state to UP"

In commit c9dca822c729 ("net-loopback: set lo dev initial state to UP"),
linux started automatically bringing up the loopback device of a newly
created namespace. However, an existing user script might reasonably have
the following stanza when creating a new namespace -- and in fact at least
tools/testing/selftests/net/fib_nexthops.sh in Linux's very own testsuite
does:

 # set -e
 # ip netns add foo
 # ip -netns foo addr add 127.0.0.1/8 dev lo
 # ip -netns foo link set lo up
 # set +e

This will now fail, because the kernel reasonably rejects "ip addr add" of
a duplicate address. The described change of behavior therefore constitutes
a breakage. Revert it.

Fixes: c9dca822c729 ("net-loopback: set lo dev initial state to UP")
Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/loopback.c