OSDN Git Service

ALSA: usb-audio: Fix undefined behavior due to shift overflowing the constant
authorBorislav Petkov <bp@suse.de>
Tue, 5 Apr 2022 15:15:08 +0000 (17:15 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 5 Apr 2022 16:22:13 +0000 (18:22 +0200)
commit1ef8715975de8bd481abbd0839ed4f49d9e5b0ff
treeb7f48de81d878cef45fdfc9527924967684c3384
parentc9db8a30d9f091aa571b5fb7c3f434cde107b02c
ALSA: usb-audio: Fix undefined behavior due to shift overflowing the constant

Fix:

  sound/usb/midi.c: In function ‘snd_usbmidi_out_endpoint_create’:
  sound/usb/midi.c:1389:2: error: case label does not reduce to an integer constant
    case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */
    ^~~~

See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory
details as to why it triggers with older gccs only.

[ A slight correction with parentheses around the argument by tiwai ]

Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lore.kernel.org/r/20220405151517.29753-3-bp@alien8.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/usbaudio.h