OSDN Git Service

nfsd: zero out pointers after putting nfsd_files on COPY setup error
authorJeff Layton <jlayton@kernel.org>
Tue, 17 Jan 2023 19:38:30 +0000 (14:38 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 20 Feb 2023 14:20:52 +0000 (09:20 -0500)
commit1f0001d43d0c0ac2a19a34a914f6595ad97cbc1d
treee8a4ef1f35ffa298216f34696a012cf6da0b0abd
parentecfa3987731b1ceb7964075cdc0235da1765622a
nfsd: zero out pointers after putting nfsd_files on COPY setup error

At first, I thought this might be a source of nfsd_file overputs, but
the current callers seem to avoid an extra put when nfsd4_verify_copy
returns an error.

Still, it's "bad form" to leave the pointers filled out when we don't
have a reference to them anymore, and that might lead to bugs later.
Zero them out as a defensive coding measure.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4proc.c