OSDN Git Service

nfp: don't dereference a null nn->eth_port to print a warning
authorColin Ian King <colin.king@canonical.com>
Thu, 6 Apr 2017 12:54:35 +0000 (13:54 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 8 Apr 2017 15:15:34 +0000 (08:15 -0700)
commit1f1120a5427c9e7894be63baaab828755e45a1c0
tree1ab2928ee6a71dda5cb4ef0222d14d7a7649d98d
parent7cb164ef5b47b2e947d8361f6f2cd4823ff01557
nfp: don't dereference a null nn->eth_port to print a warning

On the case where nn->eth_port is null the warning message
is printing the port by dereferencing this null pointer.
Remove the deference to avoid a crash when printing the
warning message.

Detected by CoverityScan, CID#1426198 ("Dereference after null check")

Fixes: ce22f5a2cbe3c627 ("nfp: separate high level and low level NSP headers")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/nfp_net_main.c