OSDN Git Service

ipv4: fib: use struct_size() in kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 31 Jan 2019 00:51:48 +0000 (18:51 -0600)
committerDavid S. Miller <davem@davemloft.net>
Fri, 1 Feb 2019 23:12:29 +0000 (15:12 -0800)
commit1f533ba6d50d0e7a104d1a2c1e1a28ee0b919a90
treec2cf86cb0a4b7b3fab69c8fd31391caf6af1422d
parentee69804714e204787ec8d06e80ec21e089f030a9
ipv4: fib: use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

instance = kzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/fib_semantics.c