OSDN Git Service

tools/bpf: fix a selftest test_btf failure
authorYonghong Song <yhs@fb.com>
Tue, 5 Feb 2019 22:28:44 +0000 (14:28 -0800)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 6 Feb 2019 02:31:22 +0000 (18:31 -0800)
commit206dafb0a3a1defec131be77b7c3e14b2731fdf1
tree0a9a39f6a927ee431faaf43da6105e00b62d2da0
parent90d304b7f7a1c9ab6cdce54d65c55e5c722f0d25
tools/bpf: fix a selftest test_btf failure

Commit 9c651127445c ("selftests/btf: add initial BTF dedup tests")
added dedup tests in test_btf.c.
It broke the raw test:
 BTF raw test[71] (func proto (Bad arg name_off)):
    btf_raw_create:2905:FAIL Error getting string #65535, strs_cnt:1

The test itself encodes invalid func_proto parameter name
offset 0xffffFFFF as a negative test for the kernel.
The above commit changed the meaning of that offset and
resulted in a user space error.
  #define NAME_NTH(N) (0xffff0000 | N)
  #define IS_NAME_NTH(X) ((X & 0xffff0000) == 0xffff0000)
  #define GET_NAME_NTH_IDX(X) (X & 0x0000ffff)

Currently, the kernel permits maximum name offset 0xffff.
Set the test name off as 0x0fffFFFF to trigger the kernel
verification failure.

Cc: Andrii Nakryiko <andriin@fb.com>
Fixes: 9c651127445c ("selftests/btf: add initial BTF dedup tests")
Signed-off-by: Yonghong Song <yhs@fb.com>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/testing/selftests/bpf/test_btf.c