OSDN Git Service

hwrng: virtio - unregister device before reset
authorMichael S. Tsirkin <mst@redhat.com>
Thu, 25 Nov 2021 18:00:17 +0000 (13:00 -0500)
committerMichael S. Tsirkin <mst@redhat.com>
Fri, 14 Jan 2022 23:50:52 +0000 (18:50 -0500)
commit2076207128948b766ef1fe344e0444fc9271a847
treeb8df7ec9d66851f4f5eb843a7d4b8b7c1a277b86
parentd9679d0013a66849f23057978f92e76b255c50aa
hwrng: virtio - unregister device before reset

unregister after reset is clearly wrong - device
can be used while it's reset. There's an attempt to
protect against that using hwrng_removed but it
seems racy since access can be in progress
when the flag is set.

Just unregister, then reset seems simpler and cleaner.
NB: we might be able to drop hwrng_removed in a follow-up patch.

Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/char/hw_random/virtio-rng.c