OSDN Git Service

exportfs: do not read dentry after free
authorPan Bian <bianpan2016@163.com>
Fri, 23 Nov 2018 07:56:33 +0000 (15:56 +0800)
committerAl Viro <viro@zeniv.linux.org.uk>
Fri, 23 Nov 2018 14:08:17 +0000 (09:08 -0500)
commit2084ac6c505a58f7efdec13eba633c6aaa085ca5
tree11c18c7638bbeb0a09ee26cacd61f3a98ad893e8
parent909e22e05353a783c526829427e9a8de122fba9c
exportfs: do not read dentry after free

The function dentry_connected calls dput(dentry) to drop the previously
acquired reference to dentry. In this case, dentry can be released.
After that, IS_ROOT(dentry) checks the condition
(dentry == dentry->d_parent), which may result in a use-after-free bug.
This patch directly compares dentry with its parent obtained before
dropping the reference.

Fixes: a056cc8934c("exportfs: stop retrying once we race with
rename/remove")

Signed-off-by: Pan Bian <bianpan2016@163.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/exportfs/expfs.c