OSDN Git Service

Input: goodix - refactor reset handling
authorHans de Goede <hdegoede@redhat.com>
Tue, 21 Sep 2021 04:08:26 +0000 (21:08 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 21 Sep 2021 05:00:25 +0000 (22:00 -0700)
commit209bda4741f68f102cf2f272227bfc938e387b51
treea31a15b283b3506eef65c1cf8e783c2a8dfeee6c
parenta2233cb7b65a017067e2f2703375ecc930a0ab30
Input: goodix - refactor reset handling

Refactor reset handling a bit, change the main reset handler
into a new goodix_reset_no_int_sync() helper and add a
goodix_reset() wrapper which calls goodix_int_sync()
separately.

Also push the dev_err() call on reset failure into the
goodix_reset_no_int_sync() and goodix_int_sync() functions,
so that we don't need to have separate dev_err() calls in
all their callers.

This is a preparation patch for adding support for controllers
without flash, which need to have their firmware uploaded and
need some other special handling too.

Reviewed-by: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20210920150643.155872-4-hdegoede@redhat.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/goodix.c
drivers/input/touchscreen/goodix.h